Closed
Conversation
gilcu3
force-pushed
the
gilcu3/alterantive_2199
branch
2 times, most recently
from
7fb2354 to
9f8995a
Compare
gilcu3
force-pushed
the
gilcu3/alterantive_2199
branch
from
9f8995a to
655fee0
Compare
Contributor
Author
|
The original reason to include the code was that it is simple enough for us to maintain, so depending on upstream would just increase our security surface, which was not desirable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2199 where we avoid adding the upstream crate directly by using a wrapper